Fixed load section for undeclared variables, tested on 3 toons, will test further later
I am having an issue with Auras, not sure of the fix yet
Code:
[2017/09/29 05:44:53] No such 'string' member 'Name'
[2017/09/29 05:44:53] bot40.mac@4003 (Aura): /if (${Me.Aura[1].Name.Length} && !${Me.AltAbility[Spirit Mastery]} && !${Me.AltAbility[Auroria Mastery]}||${Me.Aura[2].Name.Length}||${AuraDelay}||${NeedLoad}) /return
[2017/09/29 05:44:53] bot40.mac@405 (Rest): /call ${RestRoutines.Arg[${i},|]}
[2017/09/29 05:44:53] bot40.mac@248 (Main(string Param0, string Param1)): /call Rest
Relevant line
Code:
/if (${Me.Aura[1].Name.Length} && !${Me.AltAbility[Spirit Mastery]} && !${Me.AltAbility[Auroria Mastery]}||${Me.Aura[2].Name.Length}||${AuraDelay}||${NeedLoad}) /return
My brain is fried, so I am not sure how to fix this currently. Everything is NULL, even when I have the Warriors aura active on the toon.
Just looked into the Auras (After a bit of debugging the fact that the INI doesn't automatically populate the needed keys!) I do not get an error. It may be related to the INI. But I cannot be certain.
It was tested on a Berserker. If while running the macro I copy and paste the above mentioned lined into a /echo I get
Code:
[2017/09/29 15:15:39] [MQ2] (14 && !NULL && !NULL||NULL||0||FALSE)
Where 14 is the integer length of my Aura (while it's present on me) first and second !NULL is for the random check of two static AltAbilities which are presumed to help with or conflict with Aura's. The NULL is the check for a second Aura which I don't use/have on me, Next is ${AuraDelay} which is hard coded into the macro, and finally a check for ${NeedLoad} which is arbitrarily /declare NeedLoad bool outer FALSE near the start of the macro, making this check quite useless as best I can tell.
Thus the Syntax is correct, everything that should return a value does. The issue must lie in the INI unless I'm missing more information. However I have traced all relevant TLO's and variables and everything comes back good.
The below information is missing INI entries on first start. Found in the log file for bot40. This makes it a PITA for new players to get going.
Additionally, when I tried to use this Macro for the first time I didn't realize that I needed to provide an assist target as a parameter, and as a way of confusing me the app told me to edit the INI entry (which wasn't present) and I added AssistPC=${Me.Name} to get the macro going but it wasn't even being read from the INI. Please consider changing this information.
The below is found on line 600. Which is found in the load sub. Recommend changing to reflect that it is a parameter and not an INI entry.
Code:
No AssistPC identified. Assign one in Bot_character_server_Berserker.ini, or restart the mac using this template: /mac bot PeteSampras
IE:
Code:
No AssistPC identified. You must supply the PC you wish to assist as a parameter when launching the macro. Example: /mac bot40 Asmallchild
Code:
[09/29/2017 14:57:34] Berserker - [ClickyNuke] ClickyNukeRecast1= is missing or not filled out correctly
[09/29/2017 14:57:34] Berserker - [ClickyNuke] ClickyNukeName2= is missing or not filled out correctly
[09/29/2017 14:57:35] Berserker - Protip: Consider editing [Combat] CombatFrequency5= to boost macro speed
[09/29/2017 15:08:43] Berserker - You are set to pull but have [Pulling] PullSkillName1= blank
[09/29/2017 15:08:43] Berserker - [Aura] AuraSpellName1= is missing or not filled out correctly
[09/29/2017 15:08:43] Berserker - [Aura] AuraName1= is missing or not filled out correctly
[09/29/2017 15:08:43] Berserker - [Aura] AuraSpellGem1= is missing or not filled out correctly
[09/29/2017 15:08:43] Berserker - [Buff] BuffSpellName1= is missing or not filled out correctly
[09/29/2017 15:08:43] Berserker - [Buff] BuffSpellIcon1= is missing or not filled out correctly
[09/29/2017 15:08:43] Berserker - [Buff] BuffSpellGem1= is missing or not filled out correctly
[09/29/2017 15:08:43] Berserker - [Buff] BuffAlias1= is missing or not filled out correctly
[09/29/2017 15:08:43] Berserker - ClickyNukeTotal=0 -- You wont use this section, consider removing section from [Settings] OptionsCheck=
Note: I changed ClickyNukeTotal to 0 from the initial 2 because it was spam casting my chestpiece (but it never actually fired, so it was ready, but it was failing to produce a command that actually casted it)
Please make note of the follow change needed in Sub Fade on line 6140. This could possibly be throughout this macro.
Code:
/for i 1 to ${FadeTotal}
/if (!${FadeUse${i}}) /next i [B][I][U]CHANGE TO /CONTINUE or /BREAK[/U][/I][/B]
/if (${${CurrentSub}Conditions${i}.NotEqual[123456]}) /varset FadeConditions${i} ${Ini[Bot_${Me.CleanName}_${MacroQuest.Server}_${Me.Class}.ini,Fade,FadeConditions${i},123456]}
/if (${Range.Between[0,${FadeUseAtMyHP${i}}:${Me.PctHPs}]} && ${FadeConditions${i}} && ${Me.AltAbilityReady[${FadeSpellName${i}}]}) {
/if (${Twisting}) /twist stop
/attack off
/if (${${CurrentSub}Announce} && ${AnnounceChannel.NotEqual[NULL]}) /docommand /${AnnounceChannel} ${${CurrentSub}SpellName${i}} --> FADING
/call ClearTarget
/call ClearAttack
/alt act ${Me.AltAbility[${FadeSpellName${i}}].ID}
/if (${OptionsCheck.Find[FeignDeath]}) /varset FDAggro TRUE
}
/next i
Line 6181 - Chang to /continue
Code:
/if (!${${CurrentSub}Use${i}}) /next i
Line 8228 - Chang to /continue
Code:
/if (!${${CurrentSub}Use${i}}) /next i
Line 7729 - This is in the Mez section. Also needs to be changed to /continue
Code:
/if (${MezTimer${MezList.Arg[${m},|]}}>6) /next m
Never mind. I'll just fix this stuff myself...lol - There's 251 instances of /next, but not all have /next issues with the change. I'll make the changes based on what I think it should do. IE: /continue or /break
