aspire2008
Iftw
- Joined
- Dec 19, 2008
- Messages
- 2,091
- Reaction score
- 9
- Points
- 38
Chatswiththisname, finally got some time to start going through and pulling out undefined variables for you:
Warriorbot.mac (may not be exclusive to this mac file and may apply to all bots)
-------
*******************
Bardbot.mac (may not be exclusive to this mac file and may apply to all bots)
------
---------
-------
Not sure what this is but keeps getting spammed in the mq2chatwindow:
------
This is also being spammed:
******************
Wizardbot.mac </subroutine><subroutine>(may not be exclusive to this mac file and may apply to all bots)
---------
--------
Shamanbot.mac
Downloaded the version posted in this thread, When I run the macro I get:
I tried to start the macro by doing /mac shamanbot ini_name
***************
Also, the change you made to mq2nav, it keeps defaulting the UseNavigation=FALSE setting in the ini files to TRUE, even when they were set to false. This is rather annoying when you aren't trying to use mq2nav to pull, and trying to use his pull path or radius pulling method instead.
I still stand by it just seems like this is an insurmountable task to go through 16 class macro files when bot.mac probably does about 80% of what dev's bots do (never used bot.mac so not really sure, but from what i read on the forums seems like it does about 75-80% of what dev's does). If you strip the pull code from dev's bots and incorporate all 3 pull methods into bot.mac it just seems like a less time consuming task.
Also, I'm sure there are more undeclared variables in the 3 macros I just sifted through, but won't know till these are probably fixed, so it spits out more undeclared variables, since its stuck in a loop.
</subroutine>
Warriorbot.mac (may not be exclusive to this mac file and may apply to all bots)
Code:
- [2017/12/14 05:40:40] WARNING: Undefined Variable aggroCheckTimerStr used on line 562@warriorbot.mac /call EchoLog ".....GROUPROLE: ${groupRole} MAINASSIST: ${mainAssist} MAINTANK: ${mainTank} ASSISTPCT: ${assistPct} AGGROCHECKTIMER: ${aggroCheckTimerStr}" TRUEMacro Paused.
Code:
- [2017/12/14 05:47:08] devCommonPremium.inc@2075 (buffCheckRoutine(string checkTypes, bool combatBuff, string onCallRoutine)): /if (${Me.Aura[1].Equal[${buffText[${nArray}]}]} || ${Me.Aura[1].Equal[${buffName[${nArray}]}]} || ${Me.Aura[2].Equal[${buffText[${nArray}]}]} || ${Me.Aura[2].Equal[${buffName[${nArray}]}]}) {
- [2017/12/14 05:47:08] devCommonPremium.inc@1711 (buffCheck(bool useTimer, bool combatBuff, string onCallRoutine)): /call buffCheckRoutine ${checkTypes} ${combatBuff} ${onCallRoutine}
- [2017/12/14 05:47:08] warriorbot.mac@107 (main(string iniNameStr, string groupRoleStr)): /if (!${minBuffCheckTimer}) /call buffCheck
- [2017/12/14 05:47:08] No such 'auratype' member 'Equal'
Bardbot.mac (may not be exclusive to this mac file and may apply to all bots)
Code:
- [2017/12/14 06:12:57] WARNING: Undefined Variable castWhileInivis used on line 381@bardbot.mac /if (!${castWhileInivis} && ${Me.Invis}) /return ABORT_INVISMacro Paused.
Code:
- [2017/12/17 19:09:50] WARNING: Undefined Variable combatGem used on line 468@bardbot.mac } else /if ((${combatSong${twistPos}.NotEqual[NULL]} || ${combatGem${twistPos}}) && !${twistTimer} && !${Me.GemTimer[${combatGem[${twistPos}]}]}) {Macro Paused.
Code:
- [2017/12/14 06:12:57] No such 'string' member 'Name'
- [2017/12/14 06:12:57] bardbot.mac@197 (main(string iniNameStr)): /if (${Me.Aura[1].Name.Equal[${auraSong}]} || ${Me.Aura[2].Name.Equal[${auraSong}]} || ${Me.Aura[1].Name.Equal[${auraText}]} || ${Me.Aura[2].Name.Equal[${auraText}]}) {
Not sure what this is but keeps getting spammed in the mq2chatwindow:
Code:
- [2017/12/14 06:19:55] Usage: /call subroutine<subroutine> [param [param...]]
This is also being spammed:
Code:
- [2017/12/14 06:20:05] [MQ2] [MQ2] >> Checking XTarget for adds
- [2017/12/14 06:20:05] [MQ2] [MQ2] >> CheckForAdds completed. newAddID: ${newAddID
- [2017/12/14 06:20:05] [MQ2] [MQ2] >> Checking XTarget for adds
- [2017/12/14 06:20:05] [MQ2] [MQ2] >> CheckForAdds completed. newAddID: ${newAddID
- [2017/12/14 06:20:05] [MQ2] [MQ2] >> Checking XTarget for adds
- [2017/12/14 06:20:05] [MQ2] [MQ2] >> CheckForAdds completed. newAddID: ${newAddID
- [2017/12/14 06:20:05] [MQ2] [MQ2] >> Checking XTarget for adds
- [2017/12/14 06:20:05] [MQ2] [MQ2] >> CheckForAdds completed. newAddID: ${newAddID
Wizardbot.mac </subroutine><subroutine>(may not be exclusive to this mac file and may apply to all bots)
Code:
- [2017/12/14 07:27:43] WARNING: Undefined Variable commandFrom used on line 4177@devCommonPremium.inc /if (${Bool[${Ini[${ININame},${INISection},${INIKey}]}]}) {Macro Paused.
Code:
- [2017/12/14 07:34:22] WARNING: Undefined Variable harvestTimer2 used on line 304@wizardbot.mac /if (${harvestSpells[${hArray}].NotEqual[NULL]} && !${harvestTimer${hArray}}) {Macro Paused.
Shamanbot.mac
Downloaded the version posted in this thread, When I run the macro I get:
Code:
couldn't open include file: C:\Macroquest2\Macros\shamanBotSettings.ini
Code:
</subroutine>
<subroutine>
I tried to start the macro by doing /mac shamanbot ini_name
***************
Also, the change you made to mq2nav, it keeps defaulting the UseNavigation=FALSE setting in the ini files to TRUE, even when they were set to false. This is rather annoying when you aren't trying to use mq2nav to pull, and trying to use his pull path or radius pulling method instead.
I still stand by it just seems like this is an insurmountable task to go through 16 class macro files when bot.mac probably does about 80% of what dev's bots do (never used bot.mac so not really sure, but from what i read on the forums seems like it does about 75-80% of what dev's does). If you strip the pull code from dev's bots and incorporate all 3 pull methods into bot.mac it just seems like a less time consuming task.
Also, I'm sure there are more undeclared variables in the 3 macros I just sifted through, but won't know till these are probably fixed, so it spits out more undeclared variables, since its stuck in a loop.
</subroutine>
Last edited: