I lot of the problem with all of these macros is that they are beyond my personal ability (I know it doesn't seem that way as often as I put out updates when I'm actively working on something). Truth be told, working on the bot40 and dev macros have been rather eye opening for me. A lot of the methods they use were foreign to me. For instance, I never consider creating a string variable that had multiple conditions in them. IE:
Code:
/noparse /declare CanCastOnMob string outer (${Target.LineOfSight} && ((${Target.Distance}<=${Spell[${${CurrentSub}SpellName${i}}].AERange}||${Target.Distance}<=${Spell[${${CurrentSub}SpellName${i}}].Range}||${Target.Distance}<=${Me.AltAbility[${${CurrentSub}SpellName${i}}].Spell.AERange}||${Target.Distance}<=${Me.AltAbility[${${CurrentSub}SpellName${i}}].Spell.Range}||${Target.Distance}<=${FindItem[${${CurrentSub}SpellName${i}}].Spell.Range})||${Spell[${${CurrentSub}SpellName${i}}].SpellType.NotEqual[detrimental]} && ${FindItem[${${CurrentSub}SpellName${i}}].Spell.SpellType.NotEqual[detrimental]}))
That's a really long and complicated if statement. But by declaring it as a string that isn't parsed it can be used in a lot simpler manner by simply typing
Code:
/if (${CanCastOnMob}) /dothethingIwant
Sure beats typing that whole string out every time I want to see if I can cast on a mob.
Additionally, having loading subs and subs seperate, I can /varset CurrentSub Lifetap
/if (!${Defined[${CurrentSub}Loaded]}) /declare ${CurrentSub}Loaded bool outer FALSE
/if (!${${CurrentSub}Loaded}) /call ${CurrentSub}Load
then in Sub Lifetap I could do all my declares/pull all the information from the INI and create INI entries if they aren't present.
which is exactly how it is done in Bot40.mac with some caveats, that some things aren't working as intended because of the update.
I'm not really programming this macro so much as I am learning the structure of the macro and applying my understanding of the major changes that broke it to the existing code.
Now, having learned a lot from looking at PeteSampras's code I could probably go on to make something myself that would likely be a useful macro to automate playing a character. One of my issues is that I dislike the way arrays are done in macros and in some cases I don't understand how they were declared or what the intention was when declaring them so I end up rewriting entire subs.
In the long run this is a learning experience for me and you, the users, are benefiting from it regardless of which macro I choose to work on. I don't play EQ. At least, not with any intention of progressing characters. I've "Played" EQ a lot lately, but every last point of EXP was attained from a macro I've worked on. At this point it totals to about 370 levels worth of EXP across all the characters I've made testing them. It'll probably be a lot more before things work correctly. I'm about to get on and start trying to work on the issues that people have messaged me about in hopes of fixing them and getting things moving a bit better. Luckily dev did work quite a bit on his own macros prior to becoming MIA after the updates. So I at least have a leg up on that.
